Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: implement maxAttempts for retryPolicy #7229

Merged
merged 7 commits into from May 24, 2024
Merged

client: implement maxAttempts for retryPolicy #7229

merged 7 commits into from May 24, 2024

Conversation

imoore76
Copy link
Contributor

@imoore76 imoore76 commented May 12, 2024 •
edited by dfawley

Fixes #4615

RELEASE NOTES:

  • grpc: add WithMaxCallAttempts to configure gRPC's retry behavior per-channel.

@imoore76
Copy link
Contributor Author

Hi @aranjans! Is there something you are waiting for from me?

@aranjans
Copy link
Contributor

@imoore76 no, i think this PR LGTM! Approved.

@dfawley dfawley assigned dfawley and unassigned aranjans May 21, 2024
dfawley
dfawley reviewed May 21, 2024
View reviewed changes
service_config.go Show resolved Hide resolved
dialoptions.go Outdated Show resolved Hide resolved
test/retry_test.go Outdated Show resolved Hide resolved
@dfawley dfawley assigned imoore76 and unassigned dfawley May 21, 2024
@dfawley dfawley added the Type: Feature New features or improvements in behavior label May 21, 2024
@dfawley dfawley added this to the 1.65 Release milestone May 21, 2024
@imoore76 imoore76 requested a review from dfawley May 22, 2024 10:09
dfawley
dfawley reviewed May 23, 2024
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR. Just one thing that needs to change: the godoc comment, and one thing that would be nice-to-have (combining test cases) if it's possible, and one small optional thing that is a judgment call that I'll leave up to you.

dialoptions.go Outdated Show resolved Hide resolved
service_config.go Show resolved Hide resolved
test/retry_test.go Outdated Show resolved Hide resolved
test/retry_test.go Outdated Show resolved Hide resolved
test/retry_test.go Outdated Show resolved Hide resolved
@dfawley
Copy link
Member

dfawley commented May 24, 2024

Thank you for the PR!

@dfawley dfawley merged commit 03da31a into grpc:master May 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfawley dfawley dfawley approved these changes

@aranjans aranjans aranjans approved these changes

Assignees

@imoore76 imoore76

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.65 Release
Development

Successfully merging this pull request may close these issues.

Retry: grpc maxretry attempts is hardcoded
3 participants
@imoore76 @aranjans @dfawley