examples: add example to illustrate the use of file watcher interceptor #7226
Conversation
Kailun2047
changed the title
|
@easwars Comments addressed. Please take another look when you get time. Thanks. |
|
@gtcooke94 Can you take a second pass on this review? Thanks! |
examples/features/authz/README.md
Outdated
| ``` | ||
|
|
||
| The client will first hit `codes.PermissionDenied` error when invoking | ||
| `UnaryEcho` although a legit username (`super-user`) is associated. This is |
There was a problem hiding this comment.
nit: UnaryEcho although a legitimate username (super-user) is associated with the RPC.
| ) | ||
|
|
||
| var ( | ||
| port = flag.Int("port", 50051, "the port to serve on") | ||
| port = flag.Int("port", 50051, "the port to serve on") | ||
| authzOpt = flag.String("authz-option", authzOptStatic, "the authz option (static or file watcher)") |
There was a problem hiding this comment.
nit: file watcher -> filewatcher
| switch *authzOpt { | ||
| case authzOptStatic: | ||
| // Create an authorization interceptor using a static policy. | ||
| staticInt, err := authz.NewStatic(authzPolicy) |
There was a problem hiding this comment.
Prefer the full name Interceptor rather than shortening to Int, please change throughout
| } | ||
| unaryAuthzInt, streamAuthzInt = fileWatcherInt.UnaryInterceptor, fileWatcherInt.StreamInterceptor | ||
| default: | ||
| log.Fatalf("Invalid authz option: %s", *authzOpt) |
There was a problem hiding this comment.
Since this example server is specifically for authz, let's put this check earlier (after parsing flags), then error log and exit the process if an invalid authz option is specified.
|
@gtcooke94 Comments addressed. Please take another look when you get time. Thanks! |
Summary of changes:
Fixes #5900
RELEASE NOTES: none