pickerwrapper: use atomic instead of locks #7214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
approved these changes
May 15, 2024
| blockingCh chan struct{} | ||
| picker balancer.Picker | ||
| // If pickerGen holds a nil pointer, the pickerWrapper is closed. | ||
| pickerGen atomic.Pointer[pickerGeneration] |
There was a problem hiding this comment.
I like atomic.Pointer a lot. atomic's unsafe.Pointer operations were terrible.
picker_wrapper.go
Outdated
| pw.pickerGen.Store(&pickerGeneration{ | ||
| blockingCh: make(chan struct{}), | ||
| }) | ||
| return pw | ||
| } | ||
|
|
||
| // updatePicker is called by UpdateBalancerState. It unblocks all blocked pick. |
There was a problem hiding this comment.
While you are here, could you please update this comment to say UpdateState instead of UpdateBalancerState. Thanks.
There was a problem hiding this comment.
Clarified that it comes from the LB policy since we have 16 different UpdateStates.
dfawley
added
the
Type: Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: none