Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leakcheck: ignore http read/write goroutine #5182

Merged
merged 3 commits into from Feb 1, 2022
Merged

leakcheck: ignore http read/write goroutine #5182

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa6703c
[leak_ignore] leakcheck: ignore http read/write goroutine
menghanl Feb 1, 2022
5b20887
[leak_ignore] not for now??
menghanl Feb 1, 2022
cb3c46e
[leak_ignore] ignore once
menghanl Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/leakcheck/leakcheck.go
View file
Open in desktop
Expand Up @@ -42,6 +42,12 @@ var goroutinesToIgnore = []string{
"runtime_mcall",
"(*loggingT).flushDaemon",
"goroutine in C code",
// Ignore the http read/write goroutines. gce metadata.OnGCE() was leaking
// these, root cause unknown, ignore for now.
//
// https://github.com/grpc/grpc-go/issues/5171
// https://github.com/grpc/grpc-go/issues/5173
"created by net/http.(*Transport).dialConn",
}

// RegisterIgnoreGoroutine appends s into the ignore goroutine list. The
Expand Down