Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: update dependency in go.mod #5179

Closed
wants to merge 2 commits into from

Conversation

menghanl
Copy link
Contributor

Generated by go get -u golang.org/x/oauth2

To fix a leaked goroutine in cloud.google.com/go@0.34.0 (which is a transitive dependency of oauth2 package)
https://github.com/menghanl/grpc-go/runs/4986286869?check_suite_focus=true

Hopefully this will fix #5173 and #5171

RELEASE NOTES: N/A

@menghanl menghanl requested a review from dfawley January 28, 2022 21:30
@menghanl menghanl added the Type: Dependencies Updating/adding/removing dependencies label Jan 28, 2022
@menghanl menghanl added this to the 1.45 Release milestone Jan 28, 2022
@menghanl menghanl force-pushed the update_dep branch 2 times, most recently from 9b77145 to 3ee8d30 Compare January 28, 2022 21:36
@menghanl
Copy link
Contributor Author

menghanl commented Jan 28, 2022

This PR is failing with the same leaked goroutine 🎉

@dfawley dfawley assigned menghanl and unassigned dfawley Jan 31, 2022
@menghanl menghanl closed this Jan 31, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: ClusterNameInAddressAttributes
2 participants