Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Add GRPCServer interface to accept different grpc.Server implementations #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion server.go
Expand Up @@ -30,11 +30,16 @@ func init() {
prom.MustRegister(DefaultServerMetrics.serverStreamMsgSent)
}

// GRPCServer lets register any grpc server implementation, e.g. *grpc.Server and *xds.GRPCServer.
type GRPCServer interface {
GetServiceInfo() map[string]grpc.ServiceInfo
}

// Register takes a gRPC server and pre-initializes all counters to 0. This
// allows for easier monitoring in Prometheus (no missing metrics), and should
// be called *after* all services have been registered with the server. This
// function acts on the DefaultServerMetrics variable.
func Register(server *grpc.Server) {
func Register(server GRPCServer) {
DefaultServerMetrics.InitializeMetrics(server)
}

Expand Down
3 changes: 2 additions & 1 deletion server_metrics.go
Expand Up @@ -2,6 +2,7 @@ package grpc_prometheus

import (
"context"

"github.com/grpc-ecosystem/go-grpc-prometheus/packages/grpcstatus"
prom "github.com/prometheus/client_golang/prometheus"

Expand Down Expand Up @@ -129,7 +130,7 @@ func (m *ServerMetrics) StreamServerInterceptor() func(srv interface{}, ss grpc.
// InitializeMetrics initializes all metrics, with their appropriate null
// value, for all gRPC methods registered on a gRPC server. This is useful, to
// ensure that all metrics exist when collecting and querying.
func (m *ServerMetrics) InitializeMetrics(server *grpc.Server) {
func (m *ServerMetrics) InitializeMetrics(server GRPCServer) {
serviceInfo := server.GetServiceInfo()
for serviceName, info := range serviceInfo {
for _, mInfo := range info.Methods {
Expand Down