Gracefully handle error response codes on features repository initialization #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation At the moment, HTTP status codes different than 200 are completely ignored. This leads to confusing error messages that don't help clients debug the issue quickly. Adding a check for the return status code helps ensure a more meaningful error message can be returned. Ideally, the body of the response should be logged rather than provided in the exception message. In the absence of a logging framework in the library, I think emitting the body in the message can help debugging.
micpalmia
force-pushed
the
fix/failed-http-call
branch
from
7c7138e
to
85e5ce9
Compare
tinahollygb
suggested changes
Sep 19, 2023
| FeatureFetchException.FeatureFetchErrorCode.NO_RESPONSE_ERROR | ||
| ); | ||
| } | ||
| if (response.code() != 200) { |
There was a problem hiding this comment.
Hi @micpalmia thanks for your contribution. Unfortunately this approach will be quite fragile and will introduce a regression. In some cases, the API returns 304 with the content, and in those cases, this will break the SDK.
https://cdn.growthbook.io/api/features/java_NsrWldWd5bxQJZftGsWKl7R2yD2LtAK8C8EUYh9L8
Please update your error check to include only error-related status codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, HTTP status codes different than 200 are completely ignored. This leads to confusing error messages that don't help clients debug the issue quickly. Adding a check for the return status code helps ensure a more meaningful error message can be returned.
Ideally, the body of the response should be logged rather than provided in the exception message. In the absence of a logging framework in the library however, I think emitting the body in the message can help debugging.
Happy to adapt as needed if you have any feedback.