Gl/adding remote eval on edge #41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazzdingo
commented
Nov 14, 2023
| @@ -0,0 +1,52 @@ | |||
| { | |||
There was a problem hiding this comment.
remove this file
gazzdingo
commented
Nov 14, 2023
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
remove this file
gazzdingo
commented
Nov 14, 2023
| @@ -33,6 +33,7 @@ | |||
| "eslint-plugin-import": "^2.28.1", | |||
| "eslint-plugin-prettier": "^5.0.0", | |||
| "prettier": "^3.0.3", | |||
| "serverless-offline-edge-lambda": "^1.3.1", | |||
gazzdingo
commented
Nov 14, 2023
| @@ -0,0 +1,13 @@ | |||
| # http://editorconfig.org | |||
| root = true | |||
There was a problem hiding this comment.
i might want to copy our rules for this or just not have these rules
gazzdingo
commented
Nov 14, 2023
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
could remove and just use the root prettier rules
gazzdingo
commented
Nov 14, 2023
| @@ -0,0 +1 @@ | |||
| export default new Response('route could not be found', { status: 404 }); | |||
There was a problem hiding this comment.
might need to use this for all the other requests to clouldflare currently not using it
gazzdingo
commented
Nov 14, 2023
| @@ -0,0 +1,24 @@ | |||
| # Default Starter Kit For TypeScript | |||
There was a problem hiding this comment.
rewirite this for GB
gazzdingo
commented
Nov 14, 2023
| @@ -1,5 +1,6 @@ | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
| import { GrowthBook, Context as GBContext } from "@growthbook/growthbook"; | |||
| import type { Polyfills } from "@growthbook/growthbook"; | |||
There was a problem hiding this comment.
remove this was testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leaving this in draft as i need to still go though and clean up a bit and write a readme/docs for them