fix: add instructions for using standard virtualenvs #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremydw
reviewed
Apr 20, 2022
README.md
Outdated
| @@ -43,6 +43,38 @@ pipenv run grow install | |||
| pipenv run grow run | |||
| ``` | |||
|
|
|||
| ## Development without pipenv | |||
|
|
|||
| If you are using standard virtual environments or a different virtual environment manager (like pyenv) you can follwo this instructions. | |||
There was a problem hiding this comment.
Fix typos; also, could you move this to a CONTRIBUTING.md if this is meant for Grow developers (not users)?
|
I moved it to |
|
@jeremydw Can you have a look at this and at the other outstanding PRs? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some developers might prefer to manage virtual environments the traditional way, or to use other virtual environment managers like pyenv (which I use). I think giving instructions on how to set up the development environment in those cases is cheap and doesn't damage the standard setup of the project.