Hide locations swap icon when fields are empty

[Altonss]

Solves #732

[ialokim]

Thanks for this!

As discussed in #733 (comment) I'm still not convinced that removing the icon button completely is the right thing to do. Especially because there is another icon left of it that might jump around.

In any case I would postpone this fix until after the release.

[Altonss]

As discussed in #733 (comment) I'm still not convinced that removing the icon button completely is the right thing to do. Especially because there is another icon left of it that might jump around.

In any case I would postpone this fix until after the release.

Oh yes this would make sense, so preferably just disable this button right?

[ialokim]

As discussed in #733 (comment) I'm still not convinced that removing the icon button completely is the right thing to do. Especially because there is another icon left of it that might jump around.
In any case I would postpone this fix until after the release.

Oh yes this would make sense, so preferably just disable this button right?

Yes, but "just" disabling might not be that easy, in the last PR we didn't find a proper way of visually disabling an IconButton, iirc.

[Altonss]

Oh I see... Then isn't hiding a good compromise? I see for example that Trainline is also hiding their swap button https://www.thetrainline.com

[ialokim]

I'm mostly concerned about the favorite icon jumping around if this gets hidden. If swap is only ever hidden when favorite is hidden, too, I think I could live with it.

[Altonss]

I'm mostly concerned about the favorite icon jumping around if this gets hidden. If swap is only ever hidden when favorite is hidden, too, I think I could live with it.

I agree!

[Altonss]

Fixed it, now the icon isn't hidden anymore: it is disabled and greyed out. It works and looks great on my device :) I'd be happy to hear your feedback !