Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Verkéiersverbond to Mobilitéitszentral and add logo #778

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muekoeff
Copy link

@muekoeff muekoeff commented Sep 1, 2021

Renames Luxembourg Verkéiersverbond to Mobilitéitszentral (since the former was dissolved earlier in 2021) and adds a logo.

SVG taken from Mobiliteit.lu.

@cla-bot
Copy link

cla-bot bot commented Sep 1, 2021

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @muekoeff on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot

@muekoeff
Copy link
Author

muekoeff commented Sep 1, 2021

I hereby fully agree to the project's Contributor License Agreement.

@Altonss
Copy link
Collaborator

Altonss commented May 19, 2023

@grote @ialokim is there something stopping this PR from getting merged?

@ialokim
Copy link
Collaborator

ialokim commented May 23, 2023

@grote @ialokim is there something stopping this PR from getting merged?

Mostly our lack of time dedicated to Transportr.

@muekoeff Do you still have the original SVG file you created the Android vector drawable from? We collect them in artwork for future reference.

@muekoeff
Copy link
Author

muekoeff commented May 24, 2023

@ialokim I used the file on their website.

@ialokim
Copy link
Collaborator

ialokim commented May 30, 2023

Great thanks! After someone adds the original svg to artwork, this should be ready to go.

@cla-bot
Copy link

cla-bot bot commented Jun 11, 2023

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @muekoeff on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot

@ialokim
Copy link
Collaborator

ialokim commented Jun 17, 2023

Thanks! Maybe someone could build this once and post screenshots here of how the logo looks both in the network list and when selected. I'd fear that it appears cut when displayed in the circle.

@pt2121
Copy link
Collaborator

pt2121 commented Jul 30, 2023

The logo is cut off a bit. If we can resize or add padding, it'd be nice.

@Altonss Altonss self-requested a review December 6, 2023 01:22
Copy link
Collaborator

@Altonss Altonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it can be merged

@Altonss
Copy link
Collaborator

Altonss commented May 13, 2024

ping @ialokim, should we merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants