Add several network logos as svg and xml #590
Conversation
cla-bot
bot
added
the
cla-signed ✔️
|
Hey, thanks a lot for working on this! I suggest to simplify the logos or find different ones in cases where they are too complex, have too many or too long paths (resulting in huge file sizes and memory usage), or use non-supported features such as gradients. E.g. the Canadian logos use a simple part of Canada's flag and the state code. |
That's what I've tried, do you think some of the proposed logos are still too complex? Not sure about simplifying with gradients neither, e.g. the SNCF Logo without a gradient would just look quite different. |
Yes, some of yours are super large. Look at the Spain logo for example, adding this crown would have made the logo similarly large, so I just left it out.
This is Paris, right? SNCF wouldn't be the good logo for that one anyway, because there's many transport agencies there. I'd suggest to find another logo. In the worst case, the eiffel tower. |
Okay, which ones would you like to have replaced? |
|
@ialokim Do you still want to complete this PR? |
|
Yeah sure, I've just been a bit short of time lately. If you prefer, you could close the PR for now and I report back when I've managed to work on it. |
|
No, if you'll continue to work on it, we can leave it open. |
|
Just so I can pick up this PR, which logos in this PR need to be changed for it to be merged? |
|
I'd guess the ones that are "super large". Feel free to replace/improve them! |
I guess that with #884 removing NZ, Oregon and California, the "super large" logos get removed anyway. |
This PR is moving forward to complete #238 by replacing several PNG network logos with SVG and XML ones:
network_aus_logo.svg(original source: Wikimedia)network_california_logo.svg(original source: Wikimedia)network_mersey_logo.svg(converted with Inkscape from PNG logo)network_ns_logo.svg(converted with Inkscape from PNG logo)network_nz_logo.svg(original source: Wikimedia)network_oregon_logo.svg(original source: Wikimedia)network_pl_logo.svg(converted with Inkscape from PNG logo)network_rt_logo.svg(original source: Wikimedia)network_sbb_logo.svg(original source: Wikimedia)All logos have been edited to fit exactly 64x64px and simplified as much as possible.
Furthermore, I have been working on three more SVG logos (for
paris,seandrtachicago), but while converting them to Android XML using SvgToVectorDrawableConverter, it seems the current minimum API version does not support gradients. How should we handle that case?