Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

IE11 fix for range input not updating #75

Merged
merged 1 commit into from Aug 10, 2016

Conversation

jwijay
Copy link
Contributor

@jwijay jwijay commented Aug 10, 2016

What does this PR do?

adds this._onChangeRange to onMouseUp React event for range input example.

What testing has been done on this PR?

Range input in grommet-docs Form example has been tested in IE11, Chrome, Safari, and Firefox.

What are the relevant issues?

grommet/grommet#241

It looks like React v15 has a known issue with updating range inputs in IE11 using the React onChange event.

Attaching the _onChangeRange function to the range input's onMouseUp event (in addition to the onChange event) appears to fix the issue for IE11.

Screenshots (if appropriate)

IE11 before fix:
ie11sliderbug

IE11 after fix:
ie11sliderfix

…xample. (IE11 fix for range slider not updating onChange).

Signed-off-by: Jackie Wijaya <jackiewijaya@webmocha.com>
@alansouzati
Copy link
Member

thanks for your investigation.

@soulprovidr
Copy link

(Just wanted to say thanks, I was able to solve our IE11 range slider issues due to this thread).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants