Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splits the behaviour inherit structure into simple and compound behaviours #46

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

italocampos
Copy link

I strongly suggest to accept this PR, because of future coding contributions and improvements. This PR splits the behaviours inherit structure into two major classes: SimpleBehaviour and CompoundBehaviour, both inheriting from the BaseBehaviour in the pade.behaviours.base module. The proper methods was moved to the respective classes. Some docstring also was added.

…iours

[Added]
- Creates a CompoundBehaviour class;

[Changed]
- Moves the lock methods to SimpleBehaviour class;
@italocampos italocampos added the refactoring Code refactoring label Jun 26, 2020
@italocampos italocampos added this to the 3.0.0 milestone Jun 26, 2020
@italocampos italocampos self-assigned this Jun 26, 2020
@filipesaraiva
Copy link
Contributor

filipesaraiva commented Jul 8, 2020

@italocampos could you explain the difference between Behaviour, BaseBehaviour and SimpleBehaviour classes?

My question is more related if we could to merge Behaviour and BaseBehaviour and if we could remove SimpleBehaviour in order to the "simple behaviours" (like OneShotBehaviour, CyclicBehaviour, etc) just extend BaseBehaviour (or Behaviour) directly.

@italocampos
Copy link
Author

To simplify the textual explanation, I will attach to this comment a class diagram with the proposed alterations. The previous version of the classes has many classes inheriting directly from BaseBehaviour. During the development, it's possible to see that compound behaviours don't share the same activities with simple behaviours. This is the reason of this PR. You can ask me for more explanation if you need to. :)

behaviours-in-pade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants