Fix for masked array bug, and change sig_ml to tiny value #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Greg,
I'm suggesting two edits with this PR:
xi
in themarginal_p
function when the gaussian option is used. By extracting the data explicitly, we can avoid the issue caused by the numpy bug detailed here: BUG (Possible): masked array divide by zero array seems to screen out nan and inf numpy/numpy#18744gaussian
marginal description on data that is not truly gaussian - for example if a categorical variable is included this can generate a negative TCS. Thus, a negative TCS is an indication that at least some of the variables in the data don't have a gaussian distribution.It would be great if you could try to code on datasets you know well.