Fix missing_presence_validation for polymorphic associations
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't look right. See the discussion on the corresponding issue. |
gregnavis
requested changes
Dec 8, 2023
| Context.create_table(:images) do |t| | ||
| t.references :imageable, null: false, polymorphic: true | ||
| end.define_model do | ||
| belongs_to :imageable, polymorphic: true, required: true |
There was a problem hiding this comment.
Required is deprecated in newer versions of Rails. Let's add a conditional here and pass required for older versions use optional for newer versions.
Additionally, we should be testing for all combinations:
- Columns are required, association is required (with covered this already)
- Columns are required, association is optional.
- Columns are optional, association is required.
- Columns are optional, association is optional.
There was a problem hiding this comment.
Deprecation was introduced in rails/rails@6576f73
Pushed more tests.
Better to have a message mentioning to add :optional/:required to the association, but it requires too many changes to the checker. Maybe this is good enough to mention just columns?
fatkodima
force-pushed
the
fix-missing_presence_validation-for-polymorphic
branch
from
b816e91
to
a6a07ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163.