Fix MissingNonNullConstraint to work with ActiveRecord.belongs_to_required_validates_foreign_key
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new option for ignoring entire databases and models backed by them. incorrect_boolean_presence_validation is the first detector that gained that new option.
…required_validates_foreign_key`
gregnavis
force-pushed
the
master
branch
2 times, most recently
from
168d951
to
d322a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.1 introduced an optimization to required
belongs_toassociation to not check for presence when foreign key's value hasn't changed (see rails/rails#46522 for details).In this PR I made
active_record_doctorbe aware of this configuration. We can assume, that if a validator has an:ifcondition and validation's message is:requiredandActiveRecord.belongs_to_required_validates_foreign_key == false, then this condition was set with the rails itself (not a conditional set by the user).