Support composite primary keys #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
commented
Aug 22, 2023
| @@ -31,6 +31,7 @@ def detect | |||
|
|
|||
| next if ignored?("#{table}.#{from_column.name}", config(:ignore_columns)) | |||
|
|
|||
| # TODO: Add support for composite primary keys when https://github.com/rails/rails/pull/47637 is merged. | |||
There was a problem hiding this comment.
That PR adds a proper way to define multi-column foreign keys and getting their metadata, which we can not get correctly currently.
There was a problem hiding this comment.
That was merged, so needs an update before merging this PR.
gregnavis
force-pushed
the
master
branch
2 times, most recently
from
168d951
to
d322a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.1+ will support composite primary keys, so I extended the gem to support this. Even though that rails 7.1 is not released yet, people on rails'
maincan already benefit from this.I also added testing for rails
mainto the CI along the way and fixed a few incorrect gemfile specifiers in the CI config file.