This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Fix unclosed response bodies that are not being used #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix unclosed resps
|
Friendly ping, can we get a merge on this one 📦 |
moul
approved these changes
May 6, 2020
CAFxX
reviewed
Feb 1, 2022
| @@ -192,11 +192,15 @@ func (t *Transport) RoundTrip(req *http.Request) (resp *http.Response, err error | |||
| for _, header := range endToEndHeaders { | |||
| cachedResp.Header[header] = resp.Header[header] | |||
| } | |||
| resp.Body.Close() | |||
There was a problem hiding this comment.
it would be ideal to do
io.Copy(io.Discard, resp.Body)
resp.Body.Close()so that the HTTP connection can also be reused
(same below)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this library, we noticed a memory leak.
We traced it too these response bodies not being able to be closed (becuase they are never passed back)