Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind C-c C-c to #'racket-run #144

Closed
wants to merge 1 commit into from
Closed

Bind C-c C-c to #'racket-run #144

wants to merge 1 commit into from

Conversation

cpitclaudel
Copy link
Contributor

This is in line with the practice of other major modes, like
python-mode. Some other modes (like haskell-mode) use this to map to a
mode-specific version of #'compile, but I'm not sure that this would be
too relevant here. What do you think?

This is in line with the practice of other major modes, like
python-mode. Some other modes (like haskell-mode) use this to map to a
mode-specific version of #'compile, but I'm not sure that this would be
too relevant here. What do you think?
@greghendershott
Copy link
Owner

Good point. I've wondered about this.

Racket does have raco make to create bytecode zo and dep files under compiled/. But in my experience usually this gets run as part of raco setup or raco pkg install -- not directly as a raco make of a specific file.

So if we were to bind C-c C-c to something "compilation related", where it saves people needing to go to a shell, maybe it should be raco setup, re issue #41 ? But I'm not sure....

@cpitclaudel
Copy link
Contributor Author

I've added a comment there :) I don't think C-c C-c should be made redundant with a properly configured M-x compile. I also expect racket-run to be much more common that compiling.

I use C-c c to run compile, and that has been pretty convenient. That could be suggested in the docs somewhere.

@greghendershott
Copy link
Owner

  1. Sorry: I confused things by mentioning issue Offer to help with bytecode mismatches? #41 in connection with this. When issue Offer to help with bytecode mismatches? #41 arises, it's almost always because some other file(s) need to be recompiled. Closing issue Offer to help with bytecode mismatches? #41 would entail doing something like what I mentioned in the first comment -- using https://github.com/rmculpepper/custom-load.
  2. I do like your comment -- which I misled you to leave over there :) -- about setting Emacs compile-command to raco make in racket-mode buffers. I'll do that.
  3. Once I do 2, is there anything left to-do on this issue? Should we leave it up to individual users to bind C-c C-c if/as they prefer? Or should we bind it to compile in racket-mode as a reasonable default? What do you think?

@cpitclaudel
Copy link
Contributor Author

Cool for 2. For 3, I would actually vote for biding C-c C-c to the same as C-c C-k, as it matches other language modes like Python-mode. I wouldn't bind it to compile, because users often already have a binding for that, and because it would be slightly inconsistent with other language modes. Of course, that wouldn't prevent users from rebinding C-c C-c.

Anyhow, this is a minor thing; it just bit me when I first tried the mode :)

greghendershott pushed a commit that referenced this pull request Jul 8, 2015
@greghendershott
Copy link
Owner

OK. Done. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants