Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clipboard destination UX #428

Open
wants to merge 2 commits into
base: release/1.3
Choose a base branch
from

Conversation

albyrock87
Copy link

@albyrock87 albyrock87 commented Aug 4, 2022

  • On clipboard notification click, open the editor
    Like the Windows' Snipping Tool, when the use clicks on the notification, the screenshot editor will open
  • When the editor was opened from a clipboard destination, prompt to copy to clipboard on close
  • Add hero image to Windows 10 notifications with the screenshot preview
    image

- On clipboard notification click, open the editor
- When the editor was opened from a clipboard CaptureMode, prompt to copy to clipboard on close
- Add hero image to Windows 10 notifications with the screenshot preview
@CLAassistant
Copy link

CLAassistant commented Aug 4, 2022

CLA assistant check
All committers have signed the CLA.

@albyrock87
Copy link
Author

@Lakritzator what do you think about this? Thanks

@Lakritzator
Copy link
Member

I was on holidays, and will look at this in the coming days. (I have a lot of catching up to do)

@Lakritzator
Copy link
Member

So I had a look at this, and having the screenshot in the notification is a nice thing.
It would be important to keep the aspect ratio for the image though!

But I am not sure, you say "on clipboard notification click, open the editor".
I get notifications whenever I export a screenshot, and when I export I do not want to open in in the editor again.

Did you want to make it in such a way, that when someone copies something to the clipboard, outside of Greenshot, there would be a notification which you can click?
Maybe you can describe what exactly is what you want to happen?

@albyrock87
Copy link
Author

@Lakritzator the Windows 10 Snipping tool works this way:

  1. User hits Win+Shift+S
  2. The capture tool appears
  3. User selects the area
  4. The area gets copied to the clipboard automatically
  5. A notification with the image appears
  6. If the user clicks on the notification, the snipping tool editor appears and the user can edit the screenshot
  7. Inside the tool the user can edit the screenshot and copy again the changed content to the clipboard or the user can save it to a file

I just wanted to implement the number 6 when the user chooses the clipboard as a destination.
In all the other use cases it makes no sense to open the editor given that the file has already been saved somewhere.

I may agree with you on the aspect ratio of the preview, but should we resize to fit and cut what cannot be inside or do we want to add black bars?
I prefer the first one.

Thanks

@DraakjeYoblama
Copy link

This was exactly the feature I was looking for, I hope it gets implemented soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants