Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Document BigQuery test dataset configuration #3273

Conversation

jdimatteo
Copy link
Contributor

@jdimatteo jdimatteo commented Aug 18, 2021

Changes proposed in this pull request:

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Aug 18, 2021

👷 Deploy request for niobium-lead-7998 pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: 1c287f8

@jdimatteo jdimatteo force-pushed the docs/clarify_bigquery_dataset_env_variable branch from 994384e to 1c287f8 Compare August 18, 2021 13:02
@jdimatteo jdimatteo marked this pull request as ready for review August 18, 2021 13:09
@jdimatteo
Copy link
Contributor Author

@Shinnnyshinshin can you please review this when you get a chance? This little documentation piece got missed when integrating our work in #3219.

Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this @jdimatteo. Looks great

@Shinnnyshinshin Shinnnyshinshin merged commit 35fd8cf into great-expectations:develop Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants