Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shop symbol: hearing_aids #4909

Merged
merged 3 commits into from Dec 24, 2023

Conversation

sommerbe
Copy link
Contributor

@sommerbe sommerbe commented Dec 4, 2023

Icon source: own work.
Rasterisation: tested with density=96,150,300,600 using ImageMagick convert

Changes proposed in this pull request:

  • shops of type "hearing_aids" are rendered with a unique icon, similar to optician.

Icon source: own work.
Rasterisation: tested with density=96,150,300,600 using ImageMagick convert
@imagico
Copy link
Collaborator

imagico commented Dec 5, 2023

Thanks for the pull request.

This needs a sample rendering for evaluation of the symbol's suitability.

Tag in question is shop=hearing_aids:

https://wiki.openstreetmap.org/wiki/Tag%3Ashop%3Dhearing_aids

Has 8.7k uses, not that much considering how widespread these are in countries with aging populations like in Europe and East Asia. But the tag describes a well delineated type of shop and it is consistently used in that meaning (despite the wiki doing an extremely poor job at a culture independent definition through copy&paste from English Wikipedia).

So in principle i am in support for adding this - subject to evaluation of the symbol.

@pnorman
Copy link
Collaborator

pnorman commented Dec 6, 2023

SVG looks technically okay, but we need a test rendering to evaluate how the symbol works. I support this in principle.

@sommerbe
Copy link
Contributor Author

sommerbe commented Dec 6, 2023

Please find attached two renderings using kosmtik of the symbol in question, commit 298e951, of two different maps, before and after this suggested change, respectively.

Map 0: after (above), before (below). See OSM.
hearing_aids-after-map0
hearing_aids-before-map0

Map 1: after (above), before (below). See OSM.
hearing_aids-after-map1
hearing_aids-before-map1

@imagico
Copy link
Collaborator

imagico commented Dec 6, 2023

Thanks for the sample renderings.

I think there is some room for improvement in recognizability here. The 14x14 pixel space provides quite a bit more room for a more explicit depiction than just a abstract shape vaguely resembling an ear.

A simple image search could provide some inspiration:

https://duckduckgo.com/?q=hearing+aid+symbol&t=h_&iar=images&iax=images&ia=images

I in particular think that a sound wave visualization (you could take that from our communication tower symbols) would be helpful.

Using: kosmtik, mapnik
Visual change: a) thicker and longer icon to better resemble the human ear; b) improves pixel grid alignment and simplicity
@sommerbe
Copy link
Contributor Author

sommerbe commented Dec 6, 2023

Thank you for your feedback. Thinking about it, I agree with a) "a more explicit depiction", b) using the entire icon space and c) a wave visualization (for which I indeed used your communication tower symbol) which I think fits nicely given the development of in-the-ear hearing aids featuring bluetooth etc.

For this new icon, I wanted to resemble the principal shape/curves of the human ear while being a bit more organic/explicit than I found with many such symbols on the web. To be honest, I think depicting human shapes isn't that easy given that humans are particular critical towards recognizing humans, as far as I know.

Below is the rendering of this new icon (no 20). Scale x1 (above), Scale x2 (below).

hearing_aids-20
hearing_aids-20-scale2

What do you think? In case we all agree, then I push this change.

@imagico
Copy link
Collaborator

imagico commented Dec 7, 2023

I like that you are trying a new take on the subject with a more organic and less abstract shape. But i am not sure if this is substantially better recognizable. Part is that the waves are going in the wrong direction (a hearing aid would be receiving sound waves on the outside, not sending them).

For comparison here a sketch combining some design ideas that can be found in the image search linked to above. This depicts a traditional above-the-ear hearing aid. I am not sure this is necessarily better recognizable as an ear, but it attempts to illustrate the actual hearing aid and this way aims to avoid the generic something with ears association.

variant 1
variant 2

I would encourage you to try tuning your design - maybe see how it looks like with the wave pattern flipped.

@sommerbe
Copy link
Contributor Author

sommerbe commented Dec 8, 2023

Here are two sketches with above-the-ear hearing aid, in following your suggestion related to the wave propagation direction, from front (above, no 25), from back (below, no 28).

hearing_aids-25
hearing_aids-28

I am under the impression that the latter sketch depicting the radio waves coming from behind fits better since these are closer to the receiver. With the receiver being more spatially apart from the human ear, compared to your suggested sketches, I find it easier to recognize the receiver.

But one may argue as to whether the human ear is better recognizable.

@HolgerJeromin
Copy link
Contributor

Interesting you argue with radio waves.
For me they are sound waves. :-)

Something with sound and the ear. Fits too IMO.

@sommerbe
Copy link
Contributor Author

sommerbe commented Dec 8, 2023

Of course they are sound waves. Just a typo. Thank you anyway for pointing it out.

@imagico
Copy link
Collaborator

imagico commented Dec 8, 2023

I think this is going in the right direction. No strong preference w.r.t. the direction of waves from me. If you choose the version from the left it might make sense to move them down a bit.

Regarding the gap between receiver and ear - yes, the hearing aid as a distinct thing is more clearly identifiable with it. But it might be less clearly readable as a hearing aid since practically such devices will always sit directly on the ear without a gap.

@dch0ph
Copy link
Contributor

dch0ph commented Dec 10, 2023

Agree with with @sommerbe that waves coming from behind is more recognisable. Big improvement on first design!

@sommerbe
Copy link
Contributor Author

Thank you.

Here are a few more drafts:

  1. no gap between receiver and ear, while sound waves are coming from behind (no 30),
    hearing_aids-30

  2. sound waves coming from the front are centered, with a gap between receiver and ear (no 31),
    hearing_aids-31

  3. sound waves coming from the front are centered, without a gap between receiver and ear (no 32),
    hearing_aids-32

  4. instead of depicting a hearing aid, a strike through line crosses the ear, with sound waves coming from the front (no 35),
    hearing_aids-35

  5. a strike through line without sound waves (no 38).
    hearing_aids-38

The more abstract symbols having a strike through line (no 35, 38) might however be ambiguous. They could resemble one of: hearing aid shop, otologist. And maybe other professionals. But I wanted to try these out, just as an experiment.

@imagico
Copy link
Collaborator

imagico commented Dec 10, 2023

I don't think the line through ear is likely going to work.

Apart from that i think there are a lot of good options presented, i would like to see some input from others on the design and the intuitive readability.

@dch0ph
Copy link
Contributor

dch0ph commented Dec 11, 2023

I don't think line through ear works. 28 followed by 30 for me.

@imagico
Copy link
Collaborator

imagico commented Dec 16, 2023

Since there are no further comments i would suggest you, @sommerbe, to pick which of the last shown variants with a hearing aid depicted (with or without gap, waves from front or back) you would like to suggest and update the PR for a full review.

@sommerbe
Copy link
Contributor Author

The symbol in question has been pushed for full review, using db87c75

The rendering using kosmtik is as follows.

Scale 1x:
hearing_aids-43

Scale 2x:
hearing_aids-43x2

Thank you for considering this suggestion for full review.

This version is based on number 28, with minor improvements and
svg optimisations (number 43). This symbol depicts the human ear
with an over-the-ear hearing aid being visually slightly separated
from the ear, as well as with sound waves propagating from behind
towards the hearing aid receiver.

Attention was given to a) uniqueness, b) visual simplicity, c)
rendering quality using kosmtik as well as png export with multiple
scaling factors (1x and 2x).
Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got around to test this now, looks good. And i think the symbol in this form is a good choice.

heading_aids

@imagico imagico merged commit 258d354 into gravitystorm:master Dec 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants