Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aerialway=magic_carpet #4650

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AntonioLagoD
Copy link

@AntonioLagoD AntonioLagoD commented Aug 17, 2022

Fixes # 4649

Changes proposed in this pull request:

  • add magic_carpet to aerialway, because it not rendering such ski lifts

Test rendering with links to the example places:

https://www.openstreetmap.org/#map=18/40.32955/-7.61252
In this place there is a magic carpet

Before

After

@danieldegroot2
Copy link
Contributor

Ref #4649 (duplicate of #3169 (comment)).

@imagico
Copy link
Collaborator

imagico commented Aug 17, 2022

Thanks for the pull request.

#3169 has been closed with the decision not to render this - this would need to be revised to accept this change.

Apart from that it seems most of these features are small, the vast majority less than a hundred meters in length. That would mean at the starting zoom level (z12) a length of just a few pixels in most cases.

@AntonioLagoD
Copy link
Author

AntonioLagoD commented Aug 17, 2022

Ref #4649 (duplicate of #3169 (comment)).

#3169 was closed 4 years ago. I didn't know that issue.
The discuss was about if they are a fixed or a temporary structure.
I think they are mostly permanent structures like chairlifts, drag lifts and gondolas. It's easy to see in google satelllite maps in most ski resorts.

I am proposing a change for rendering them adding only two lines to aerialways.mss
Not rendering these structures will remain in a lack of precision.
I include some link to google satellite images showing magic carpets out of winter season:
https://www.google.es/maps/@40.3306288,-7.6140685,213m/data=!3m1!1e3?hl=es&authuser=0
https://www.google.es/maps/@43.0544945,-5.395534,72m/data=!3m1!1e3?hl=es&authuser=0
https://www.google.es/maps/@43.0425248,-5.388355,86m/data=!3m1!1e3?hl=es&authuser=0
https://www.google.es/maps/@43.0365816,-5.39643,61m/data=!3m1!1e3?hl=es&authuser=0
https://www.google.es/maps/@42.7029954,-0.2745188,244m/data=!3m1!1e3?hl=es&authuser=0
https://www.google.es/maps/@42.7781262,-0.4109055,290m/data=!3m1!1e3?hl=es&authuser=0
https://www.google.es/maps/@42.568172,1.641459,146m/data=!3m1!1e3?hl=es&authuser=0
https://www.google.es/maps/place/6450+S%C3%B6lden,+Austria/@46.9767072,10.9741966,135m/data=!3m1!1e3!4m5!3m4!1s0x479d325b54281ac7:0x4d28dbae2ec3df3f!8m2!3d46.9654937!4d11.0076232?hl=es&authuser=0

@imagico
Copy link
Collaborator

imagico commented Aug 17, 2022

I suggest to have discussion if or if not to render this on #3169.

Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my eyes this will require more work than just adding this as yet another aerialway type - mostly because aerialway=margic_carpet is different in meaning to the map user, both those who might want to use it in its function and those who see this merely as an artefact/obstacle.

As written in #3169 (comment) - if you want to work on that it would be important to consider the following:

  • consider the typical size of these in rendering.
  • consider that these are very different in meaning both to the user (in winter) and when it is not operational (as an obstacle) compared to actual aerialways in the true sense of the term.
  • consider that rendering these but not rendering highway=footway + conveying=yes in a distinct fashion would probably lead to a problematic mapping incentive.

I'd encourage you to work on this but be aware that this will require both more coding and more actual design work. Especially finding a good solution to display highway=footway + conveying=yes could be quite challenging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants