Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render bus stations more prominantly #4391

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kolgza
Copy link
Contributor

@kolgza kolgza commented Apr 27, 2021

Fixes #4390

This PR attempts to increase rendering for amenity=bus_station without making the map too busy. Between zoom levels 13 and 16, amenity=bus_station will render as small blue squares, the width of each icon at each zoom level being identical to railway=halt.

This PR does not affect how bus stations render at zoom levels z>=16. Personally, however, I think it is worth noting how seamless the transition between the generic blue square and the bus station pictograph is when zooming in from z=15 to z=16.

Changes proposed in this pull request:

  • Change style/amenity-points.mss to render amenity=bus_station at z>=13
    • Use symbols/square.svg at z<16
      • Rendering is unaffected where z>=16
    • The marker width at each zoom level is the same as for railway=halt

Test rendering with links to the example places:

Los Angeles

Before

image

After

image

Pittsburgh

Before

image

After

Screenshot_2021-04-23 OpenStreetMap Carto — Kosmtik(2)

Paris

Before:

image

Overpass Turbo query for amenity=bus_station:

image

At z=13

Paris 2

At z=15

Paris 3

At z=16 (unchanged)

Paris 4

@imagico
Copy link
Collaborator

imagico commented Sep 19, 2021

I am fairly critical of this for a number of reasons:

  • it explicitly seems to be designed to cater a non-consensus overloading of the tag amenity=bus_station to map bus stops considered 'high importance' (for some essentially subjective or local context dependent definition of importance).
  • reusing the bus stop symbol for bus stations at z13-z15 further supports mappers in the wrong assumption that bus stations are just high importance bus stops (which is not how the tag is predominantly used).
  • it moves down the starting zoom level from z16 to z13 - three levels, which is a massive change in map design without discussing the effects this has on the map in general. The balance of what we show and what we don't show is fairly delicate especially at the mid zoom levels so just starting to add some POI type three zoom levels down is going to significantly mess with that balance.
  • we typically start rendering labels for POI symbols one or two zoom levels after we start rendering the symbol. Your change would mean the symbol starts at z13 while the label starts at z17 which would make it highly unique in this style.

What would go a long way towards convincing me of the merits of this change is if you can show me how for normal use of the tag (as documented on the wiki) this change would have a positive effect on the map - in particular at relatively low latitudes where the map is dense.

@jeisenbe
Copy link
Collaborator

amenity=bus_station is more similar to a light rail station, subway station or tram stop than a railway station. In contrast, station=subway and tram=stop are not rendered till z14. I would suggest testing amenity=bus_station with the smaller icon at z14, and the text label at z15.

@imagico the bus stop and train station icons are currently both blue squares (buses are light blue, the transport color, while railway stations are darker), and in your alt-colors branch the stations are still the same color though buses have been changed to purple along with other transportation icons, matching with airports. Do you have other ideas about an icon change or color change that would help here?

@imagico
Copy link
Collaborator

imagico commented Sep 20, 2021

Well - the train station / train halt rendering is cartographically very different from the bus stop rendering because the symbol is located on the railway track which is always shown as context (OpenTopoMap here for example goes a step further and orients the symbol in direction of the railway track) while for the bus stop the symbol is more or less hanging in the air without a clear context - and it is not uncommon that at z16 it is not quite clear what road a bus stop is on (like here).

The current strong color combined with the fairly heavy weight of the bus stop squares, the lack of context and the fact that bus stops tend to be mapped separately for both sides of the road so they tend to show up in pairs - this all leads to a less than optimal rendering result. And tagging of public transport has evolved quite a bit (though there is no full agreement among mappers on this of course). So i think it would be valuable if someone would look into if some better interpretation of mapping is possible within the constraints we have here, in particular for the early zoom levels (~z15-z17). This requires finding out which mapping and tagging techniques have broad acceptance and consistent use, what kind of contextualized styling could work at lower zoom levels and how that could be generated without too much computational costs and code complexity. I know that is a tough call - but IMO the direction in which we have the most room to improve here.

Copy link
Collaborator

@jeisenbe jeisenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest testing amenity=bus_station with the smaller icon at z14, and the text label at z15.

// use colors from SVG to allow for white background
marker-clip: false;
}
[zoom < 16][zoom >=13] {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we would have this part above, using [feature = 'amenity_bus_station'][zoom >= 13], then [zoom >= 16] below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render bus stations at lower zoom levels.
3 participants