Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import natural=earth_bank as a linestring #4013

Merged
merged 1 commit into from Feb 6, 2020
Merged

Import natural=earth_bank as a linestring #4013

merged 1 commit into from Feb 6, 2020

Conversation

jeisenbe
Copy link
Collaborator

@jeisenbe jeisenbe commented Jan 28, 2020 •
edited

Related to #3611 and #2288

(Fixed version of #4012)

Changes proposed in this pull request:

  • Add natural=earth_bank to the list of linestring exceptions in openstreetmap-carto.lua so that closed ways with this tag will not be imported as polygons, but as a linestring only.
  • This tag is only used on lines, similarly to natural=cliff or man_made=embankment
  • While it is not currently rendered, there are over 4,000 features with this tag, including 202 closed ways (where the bank encircles an area) which are not intended to represent areas. http://overpass-turbo.eu/s/Qa3
  • Adding this to the lua transformations file will make it easier to render this feature correctly in the future or in other map styles which are based off of this style.

@jeisenbe jeisenbe added the lua label Jan 28, 2020
@pnorman pnorman merged commit 3c50c18 into gravitystorm:schema_changes Feb 6, 2020
@jeisenbe jeisenbe deleted the schema-earth_bank branch February 6, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lua
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeisenbe @pnorman