Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move highway areas below all linear road types #3872

Closed

Commits on Sep 6, 2019

  1. Move highway areas below all linear road types

    This PR moves highway areas below all linear road types (resolves gravitystorm#3281).
    
    In particular, this change has the following effects:
    
    * Render highway areas below tunnels (resolves gravitystorm#529). This prevents the current
      situation where tunnels are invisible if there happens to be a highway area
      above them.
    * Render highway areas below line/area barriers, ferry routes, tourism
      boundaries, cliffs, landuse-overlay, and turning circles. I think these
      changes are mainly neutral or positive.
    * Render highway areas below line/area barriers. This is probably the most
      controversial aspect (but necessary for the other changes). See screenshot
      below.
    
    * This PR is a necessary condition for merging the roads-casing and roads-fill
      layers (part of gravitystorm#2046), which would greatly simplify our code.
    * This PR is a necessary condition for rendering buildings above highway area
      (gravitystorm#688).
    
    * Promoting linear highways over areas makes life easier for other data
      consumers, that already tend to have poor support for highway areas. For
      example:
      * Transport and wikipedia do not render road areas
      * Humanitarian, bicycle, mapbox, streets, OSM bright renders linear roads on
      top of areas, like in this proposal
    Matthijs Melissen committed Sep 6, 2019
    Copy the full SHA
    2dc7a21 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2019

  1. Change highway area color

    Matthijs Melissen committed Sep 15, 2019
    Copy the full SHA
    68d4911 View commit details
    Browse the repository at this point in the history