Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for leisure=track on lines #3443

Merged
merged 1 commit into from Oct 12, 2018
Merged

Add rendering for leisure=track on lines #3443

merged 1 commit into from Oct 12, 2018

Conversation

Adamant36
Copy link
Contributor

This PR adds rendering for leisure=track on lines. As it is they are currently rendered on areas but not on ways. Closes #2632
https://www.openstreetmap.org/#map=18/39.19833/-122.02187 (location 1)
track loction 1
https://www.openstreetmap.org/#map=18/39.14384/-121.67329 (location 2)
track location 2
There is also some other related issues in #2632 that it potentially closes, but I wasn't sure which ones. So I can add them later. Also, the line is a little thin and tracks are usually pretty wide. So maybe it could be made wider.

@Tomasz-W
Copy link

Tomasz-W commented Oct 9, 2018

Also, the line is a little thin and tracks are usually pretty wide.

They should be mapped as areas then. We need leisure=track ways rendering for showing them at least as lines in cases where satellite image is too bad to draw an area, so people map them as ways through their middle (I think we shouldn't interpretate their possible landcovering width), and for unusual things like #3436. It also should match water slides rendering, so I'm OK with this width.

@Tomasz-W Tomasz-W mentioned this pull request Oct 9, 2018
26 tasks
@Adamant36
Copy link
Contributor Author

@Tomasz-W, good call. I agree.

@kocio-pl kocio-pl merged commit 4b9771d into gravitystorm:master Oct 12, 2018
@kocio-pl
Copy link
Collaborator

Thanks, this was a long missing feature.

@Adamant36 Adamant36 deleted the track branch October 12, 2018 06:09
@Tomasz-W
Copy link

I've just found that there are no bridge rendering for leisure=track lines, Here is an exemple why it should be added for better readability.

https://www.openstreetmap.org/way/327635778

@Adamant36 Could you take care of that?

@Adamant36
Copy link
Contributor Author

I'll look into it. Its also tagged as a summer toboggan. Which is something ive been meaning to work on. I think the track tag is wrong in this just and just so it will render.

@Adamant36
Copy link
Contributor Author

Well, I guess it says to add track to it on the wiki page. I think its a stretch though since summer toboggans aren't racing tracks per say.

It also begs the question, if all of the summer toboggans are suppose to tag as tracks, then whats the point in added rendering for them? If there is none because they are covered by track rendering (which personally I dont think they should be) you might want to request the summer toboggan be closed. I feel like the track tagging is worth looking into more though just in case.

@Adamant36
Copy link
Contributor Author

@Tomasz-W, can you open a new for it please so it doesn't get lost and people can discuss it if they want?

@Tomasz-W
Copy link

@Adamant36 #3592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering leisure=track on lines
3 participants