Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render bus stations at lower zoom levels. #4390

Open
kolgza opened this issue Apr 27, 2021 · 6 comments · May be fixed by #4391
Open

Render bus stations at lower zoom levels. #4390

kolgza opened this issue Apr 27, 2021 · 6 comments · May be fixed by #4391

Comments

@kolgza
Copy link
Contributor

kolgza commented Apr 27, 2021

The tag amenity=bus_station is used in two primary ways:

  1. for busway stations along a BRT corridors
  2. for transportation hubs in which multiple bus routes converge (the original intended use of this tag)

Both uses of this tag suggests that amenity=bus_station describes important pieces of transportation infrastructure wherever it is used.

Actual behavior

amenity=bus_station is rendered at z=15, the same zoom level in which highway=bus_stop is rendered.

Expected behavior

amenity=bus_station should be rendered identically to how railway=halt is rendered.

@kolgza kolgza linked a pull request Apr 27, 2021 that will close this issue
@matkoniecz
Copy link
Contributor

amenity=bus_station should be rendered identically to how railway=halt is rendered.

You mean zoom level, not icon - right?

@kolgza
Copy link
Contributor Author

kolgza commented May 27, 2021

yes

@jeisenbe
Copy link
Collaborator

I agree that this could make sense. @kolgza have you tested this out? Were you considering a PR?

@kolgza
Copy link
Contributor Author

kolgza commented Sep 19, 2021

I had submitted a PR for this (#4391), but I've stopped working on it (actually, I've stopped working on all PRs).

@kolgza
Copy link
Contributor Author

kolgza commented Sep 19, 2021

I'd like to copy @imagico's comment here:

I am fairly critical of this for a number of reasons:

  • it explicitly seems to be designed to cater a non-consensus overloading of the tag amenity=bus_station to map bus stops considered 'high importance' (for some essentially subjective or local context dependent definition of importance).

  • reusing the bus stop symbol for bus stations at z13-z15 further supports mappers in the wrong assumption that bus stations are just high importance bus stops (which is not how the tag is predominantly used).

  • it moves down the starting zoom level from z16 to z13 - three levels, which is a massive change in map design without discussing the effects this has on the map in general. The balance of what we show and what we don't show is fairly delicate especially at the mid zoom levels so just starting to add some POI type three zoom levels down is going to significantly mess with that balance.

  • we typically start rendering labels for POI symbols one or two zoom levels after we start rendering the symbol. Your change would mean the symbol starts at z13 while the label starts at z17 which would make it highly unique in this style.

What would go a long way towards convincing me of the merits of this change is if you can show me how for normal use of the tag (as documented on the wiki) this change would have a positive effect on the map - in particular at relatively low latitudes where the map is dense.

#4391 (comment)

I don't really have a response to it, but I think it's relevant.

@jeisenbe
Copy link
Collaborator

Looking at this more closely, amenity=bus_station is more similar to a light rail station, subway station or tram stop than a railway station. We render railway=station at z12 since these can be found in rural areas or small towns where they are the most important general map feature for many kilometers, and similarly railyway=halt is mostly a rural feature and starts at z13. In contrast, station=subway and tram=stop are not rendered till z14.

I would suggest testing amenity=bus_station with the smaller icon at z13 or z14

We should probably also wait to render station=light_rail and station=funicular till z13 or z14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants