New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net 1043 #780

Merged

abhishek9686 merged 2 commits into develop from NET-1043

May 17, 2024

Collaborator

theguy951357 commented May 5, 2024

Describe your changes

sends a ticket to kitemaker when an issue is opened

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

My changes affect only 10 files or less.
I have performed a self-review of my code and tested it.
If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
If it is a bugfix, my code is <= 200 lines.
My functions are <= 80 lines.
I have had my code reviewed by a peer.
My unit tests pass locally.
Netclient & Netmaker are awesome.

theguy951357 added 2 commits

May 4, 2024 15:05


          send to kitemaker ticket


          inherit secrets

d1f06d2

Aceix approved these changes

View reviewed changes

Aceix requested review from yabinma and abhishek9686

May 7, 2024 04:54

abhishek9686 approved these changes

View reviewed changes

abhishek9686 merged commit 48279ed into develop

9 of 10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment