Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add clarifying note for composite and expand term #1078

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore: add clarifying note for composite and expand term #1078

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e12b944
remove mentions of composite
JoviDeCroock Feb 13, 2024
045a347
Apply suggestions from code review
JoviDeCroock Feb 14, 2024
b18d85b
add note
JoviDeCroock Mar 8, 2024
efe71bd
Capitalise first letter in note block
JoviDeCroock Mar 27, 2024
7574e75
remove the term and alter the wording
JoviDeCroock Mar 27, 2024
1d1b2ca
typo
JoviDeCroock Mar 27, 2024
a80709a
Merge branch 'main' into clarify-composite
JoviDeCroock Mar 27, 2024
3eb62cb
Update spec/Section 5 -- Validation.md
JoviDeCroock Mar 27, 2024
6a7d602
Update spec/Section 5 -- Validation.md
JoviDeCroock Mar 27, 2024
7222ffb
Update spec/Section 5 -- Validation.md
JoviDeCroock Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions spec/Section 5 -- Validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ SameResponseShape(fieldA, fieldB):
- If {typeA} or {typeB} is Scalar or Enum:
- If {typeA} and {typeB} are the same type return {true}, otherwise return
{false}.
- Assert: {typeA} and {typeB} are both composite types.
- Assert: {typeA} and {typeB} are both Object, Interface or Union types.
JoviDeCroock marked this conversation as resolved.
Show resolved Hide resolved
- Let {mergedSet} be the result of adding the selection set of {fieldA} and the
selection set of {fieldB}.
- Let {fieldsForName} be the set of selections with a given response name in
Expand All @@ -455,6 +455,9 @@ SameResponseShape(fieldA, fieldB):
- If {SameResponseShape(subfieldA, subfieldB)} is {false}, return {false}.
- Return {true}.

Note: In prior versions of the spec the term "composite" wass used to signal
a type that is either an object-, interface- or union-type.
JoviDeCroock marked this conversation as resolved.
Show resolved Hide resolved

**Explanatory Text**

If multiple field selections with the same response names are encountered during
Expand Down Expand Up @@ -910,7 +913,7 @@ fragment inlineNotExistingType on Dog {
}
```

#### Fragments on Composite Types
#### Fragments on Object, Interface or Union Types

**Formal Specification**

Expand Down