Add a resolveNode option to allow input data to be used for the edges in a connection rather than the node
#197
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
mzikherman
force-pushed
the
resolve_node
branch
from
ded4219
to
9793f40
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
mzikherman
force-pushed
the
resolve_node
branch
2 times, most recently
from
430a877
to
f6e11c7
Compare
mzikherman
force-pushed
the
resolve_node
branch
from
f6e11c7
to
01a48d4
Compare
| @@ -28,7 +28,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "prepublish": "./resources/prepublish.sh", | |||
| "test": "npm run lint && npm run check && npm run testonly", | |||
| "test": "yarn lint && yarn check && yarn testonly", | |||
There was a problem hiding this comment.
This is bad practice; non yarn users/environments (the majority, and industry standard) will not be able to run the script. Yarn knows to substitute npm run for yarn automatically when running npm scripts.
I have a use case where I'd like to make a proper connection out of some data, and where the data itself represents edges, rather nodes. Essentially, imagine an API that returns relational join-model data- this would be the edges between the joined models, rather than the nodes/models themselves.
One way to accomplish this is to munge the data and transform it yourself before passing it to
connectionFromArraySlice, which doesn't support populating edges with any fields besidesnodeandcursor.So, I was thinking
resolveNodecould be a supported option where: if present, signifies that the data represents edges and nodes (so return those values in the edge), and also defines how to resolve the node from the data. This could make it easier to work with APIs/data that return join information.As a side note- I updated some commands in
package.jsonand the instructions in the README to referenceyarnovernpm.