Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add checks for actual deferral #3991

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

add checks for actual deferral #3991

wants to merge 2 commits into from

Commits on Nov 23, 2023

  1. do not emit pending for empty non-published subsequent results 

    The publish method checks to see if a subsequent result is empty; this same logic should be employed to suppress pending notices for empty records.

This has already been achieved for subsequent results that are children of the initial result, as we generated the pending notices from the list of initially published records.

For subsequent results that are children of other subsequent results, we previously generated the pending notice prior to actually publishing.

This change integrates the logic: the publishing method itself returns a pending notice as required. This results in a bug-fix for subsequent records of other subsequent records as well as a reduction of code for subsequent results to the initial result.
    @yaacovCR
    yaacovCR committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    af18110 View commit details
    Browse the repository at this point in the history

  2. add checks for actual deferral

    @yaacovCR
    yaacovCR committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4203dda View commit details
    Browse the repository at this point in the history