fix: use the default query on adding a new tab

[cimdalli]

When a new tab is added, it sets the query value as an empty string instead of defaultQuery value. Tab default query value should be defaultQuery variable if it's set on the component. Otherwise, it should be DEFAULT_QUERY constant.

[changeset-bot]

🦋 Changeset detected

Latest commit: 00aba1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@graphiql/react	Patch
graphiql	Patch
@graphiql/plugin-code-exporter	Patch
@graphiql/plugin-explorer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: cimdalli / name: Okan Cetin (94b5645, 1f497d3, 00aba1d, 64aa227, 544cbe1)
• ✅ login: acao / name: Rikki Schulte (ef4b1f7)

[acao]

makes sense to me. do any other @graphql/graphiql-maintainers have feelings about this?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.81%. Comparing base (79d1d99) to head (ef4b1f7).

❗ Current head ef4b1f7 differs from pull request most recent head 00aba1d. Consider uploading reports for the commit 00aba1d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3441      +/-   ##
==========================================
+ Coverage   55.31%   55.81%   +0.49%     
==========================================
  Files         115      114       -1     
  Lines        5351     5305      -46     
  Branches     1451     1443       -8     
==========================================
+ Hits         2960     2961       +1     
+ Misses       1965     1912      -53     
- Partials      426      432       +6     

Files	Coverage Δ
packages/graphiql-react/src/editor/context.tsx	73.87% <100.00%> (+0.47%)	⬆️

... and 14 files with indirect coverage changes

[benjie]

I'm for this change 👍

[acao]

two things:

1. the cypress suite is failing on some tests you added
2. the headers prop is a bit nuanced - however if it is set, then defaultHeaders should always be overridden. query, variables and headers prop, and soon extensions, should drive a controlled component state, at least I think? For 4.x I'm considering dropping all the controlled component props with a migration path to the @graphiql/react hooks instead, because it leads to a much more perfomant and easier to implement controlled component implementation

[acao]

@cimdalli so it seems this clashes a bit with previously expected behavior:

when headers are supplied, they should only set the first tab, and not be used for new tabs apparently?

so we need to revert this for headers and do the same for query/defaultQuery. otherwise, it's a change in functionality and requires a new minor version

CC @dimaMachina who added tests for this expectation, what do you think?