New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Don't convert single \n to <br> #3414
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a6e9612 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3414 +/- ##
==========================================
+ Coverage 55.75% 55.84% +0.09%
==========================================
Files 110 110
Lines 5243 5257 +14
Branches 1426 1433 +7
==========================================
+ Hits 2923 2936 +13
Misses 1897 1897
- Partials 423 424 +1
|
@leonardehrenfried thank you for this, this is exactly how it should behave, I agree. I recall there was disagreement some years back and again with the redesign about this, I will look up some issues/discussions/? when I have more time. @thomasheyenbrock or @jonathanawesome what do you think? one last thing, can you add a changeset as per the changset bot comment? then it'll be ready to go! (we used to use conventional commits with lerna but contributors had issues, switched to changesets but I miss conventional commits often. i'm looking into ways to perhaps combine them, so many ways to go about it!) |
@acao I've added a changeset. I hope I'm bumping the right packages. |
awesome, thanks @leonardehrenfried ! I think we would make this a minor release for @graphiql/react as well |
fe77126
to
a6e9612
Compare
Changeset was updated. |
Could I perhaps have another review for this? |
hey thanks for this! i'll come back to this later today or tomorrow and release it with some other new features for this |
Lovely thanks! |
Could I perhaps have another review for this, please? |
@acao Isn't this good to merge? |
sorry I hope to have more time for this in the coming months. my current commitments are for my day job and for a grant to work on the GraphQL LSP server that I'm wrapping up |
I totally understand. Thanks for maintaining GraphiQL! |
i think the only thing still stumping me is whether this constitutes a breaking change for some use cases, and whether there is some kind of markdown it config that solves the issue this intended to solve? maybe it was a workaround for the previous markdown library, was it marked? I need to look at the original history from, say, tag 0.7.y era or earlier to determine what the original purpose was |
As described in #3155 we (OpenTripPlanner) tend to have quite long, multi-paragraph descriptions of our fields.
In Markdown a single
\n
is ignored and only two\n
should lead to a new paragraph being started.markdown-it makes this fairly easy to achieve, which is why this PR is tiny.
Before
After
I've also taken the liberty to update the dev instructions.
Many thanks for this wonderful tool!