add comments

graphql · Feb 27, 2024 · 02d6a9c · 02d6a9c
1 parent 593eecd
commit 02d6a9c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/graphql-language-service-server/src/__tests__/MessageProcessor.spec.ts b/packages/graphql-language-service-server/src/__tests__/MessageProcessor.spec.ts
@@ -31,7 +31,7 @@ const genSchemaPath =
 //   this may be cumbersome with offset position assertions but possible
 //   if we can create consistency that doesn't limit variability
 // - convert each it() into a nested describe() block (or a top level describe() in another file), and sprinkle in it() statements to replace comments
-// - fix TODO comments where bugs were found that couldn't be resolved quickly (2-4hr timebox)
+// - fix TODO comments where bugs were found that couldn't be resolved quickly (2-4hr time box)
 
 describe('MessageProcessor with no config', () => {
   afterEach(() => {
@@ -327,7 +327,7 @@ describe('project with simple config and graphql files', () => {
       position: { character: 20, line: 17 },
     });
     expect(schemaDefs[0].uri).toEqual(URI.parse(genSchemaPath).toString());
-    // note: if the graphiql test schema changes, 
+    // note: if the graphiql test schema changes,
     // this might break, please adjust if you see a failure here
     expect(serializeRange(schemaDefs[0].range)).toEqual({
       start: {
@@ -436,7 +436,10 @@ describe('project with simple config and graphql files', () => {
     //   'b/schema.graphql',
     //   schemaFile[1] + '\ntype Example1 { field:   }',
     // );
-    // TODO: this didn't work at all, how to register incomplete changes to model autocomplete, etc?
+    // TODO: this didn't work at all for multi project,
+    // whereas a schema change works above in a single schema context as per updating the cache
+    //
+    // how to register incomplete changes to model autocomplete, etc?
     // await project.lsp.handleWatchedFilesChangedNotification({
     //   changes: [
     //     { uri: project.uri('b/schema.graphql'), type: FileChangeType.Changed },

diff --git a/packages/graphql-language-service-server/src/__tests__/__utils__/MockProject.ts b/packages/graphql-language-service-server/src/__tests__/__utils__/MockProject.ts
@@ -4,7 +4,6 @@ import { Logger as VSCodeLogger } from 'vscode-jsonrpc';
 import { URI } from 'vscode-uri';
 import { FileChangeType } from 'vscode-languageserver';
 import { FileChangeTypeKind } from 'graphql-language-service';
-import { mock } from 'fetch-mock';
 
 export type MockFile = [filename: string, text: string];
 
@@ -74,6 +73,7 @@ export class MockProject {
       loadConfigOptions: { rootDir: root },
     });
   }
+
   public async init(filename?: string, fileText?: string) {
     await this.lsp.handleInitializeRequest({
       rootPath: this.root,