Introduce Lookup Directive. #30
Draft
+82
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilkisiela
approved these changes
Apr 11, 2024
dariuszkuc
reviewed
Apr 12, 2024
dariuszkuc
reviewed
Apr 12, 2024
dariuszkuc
reviewed
Apr 12, 2024
| When an entity resolver returns an interface all implementing types are inferred | ||
| as entities. | ||
| Lookup fields may return object, interface or union types. In case a lookup | ||
| field returns an interface or union type all possible object types are |
There was a problem hiding this comment.
Since unions don't have to share any fields I am unsure whether we should support it (as it definitely complicates things).
There was a problem hiding this comment.
We do ... in the composition we make sure that all union members are entities.
dariuszkuc
reviewed
Apr 12, 2024
| version: Int # NOT an entity resolver. | ||
| personById(id: ID!): Person @entityResolver | ||
| version: Int # NOT a lookup field. | ||
| personById(id: ID!): Person @lookup |
There was a problem hiding this comment.
another use case would be for batching but we would then need some semantics to match the plural arg to a field (using @is?)
type Query {
person(ids: [ID!]!): [Person] @lookup
}... but this would really mess up with @require arguments so for simplicity maybe we should not allow it?
There was a problem hiding this comment.
This is being solved transparently ... so there should be no batching fields.
dariuszkuc
reviewed
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
@entityReslolverto@lookupand introduces the agreed characteristics to the specification.TODOs: