Tornado support

[ewhauser]

DroneDeploy has recently released our GraphQL APIs on top of graphene and tornado. As part of this, we ported graphene-django over to tornado and have made it available as open source.

Long term, I believe this should exist in the graphql-python project so that it is more discoverable and we are happy to contribute it back to the project. I could not find any details on how to contribute, so please let me know if there is interest and the process.

Thanks.

[syrusakbary]

Hi @ewhauser, I would love to have the project under graphql-python, while conserving you as main contributors/maintainers to the repo.

If you like the idea let me know and I will setup things so we are able to move it over :)

[ewhauser]

Happy to go that direction. Just let me know what we need to do.

[kinow]

For a project, I would like to compare flask+graphql, and tornado+graphql. Happy to dedicate some hours coding/testing/or helping with documentation if necessary. Will probably go through the existing code, and try using the latest version of libraries, plus some sample code, to see if everything works fine.

[codeocelot]

Thank you very much DroneDeploy for sharing your work! I've been playing with this code for a bit of time now, and I think it's a great addition to the python-graphql ecosystem. It would be great to find a home for this project because I've got a handful of minor contributions, including adding support for python3.7.

@syrusakbary can you set things up to move this project over so we can start contributing?

[p11o]

First glance, that repo is on python 2.7 using tornado 4. I would recommend at minimum updating both of those.

@ewhauser I'd be interested in plotting out a roadmap and contributing.

[ewhauser]

• There was a PR that was merged earlier this year that makes it compatible with Python 3 although that is not currently reflected in the README file. As far as I know there are no blockers using this with Python 3 as-is although I have not tested it myself
• We should probably have the tests running via tox for both Python 2 and 3
• DroneDeploy continues to need Python 2 support for the near future (and it is fairly trivial to support both versions) so I don't see a need to go Python 3 only
• No blockers in upgrading to Tornado 5
• Happy to merge PRs for all of these things

@syrusakbary - Still waiting on you for moving this repo over to graphql-python.

[syrusakbary]

Sorry for missing it. I just added you perms (@ewhauser) to be part of the org.
You should be able to transfer the repo over to graphql-python now :)
(let me know if you can't)

[ewhauser]

Repo moved - all set. I'll close this issue and we get started over there.

Thanks!

[ewhauser]

@syrusakbary - One more thing. Can you give me the ability to manage that project? Need to be able to merge PRs.

[syrusakbary]

@ewhauser I’ve just added you admin rights on the repo.

[felipefaraco]

Do you guys have an example based on graphene-tornado to share ? I'm new to graphql/graphene and struggling a bit to understand this library.

[ewhauser]

Any of the examples for Graphene should apply to graphene-tornado. The only difference is that your resolvers need to be async. See the README at https://github.com/graphql-python/graphene-tornado.