fix: returned string of BigInt.toHexString

[fewwwww]

For The Graph's graph-ts implementation, BigInt.toHex() and BigInt.toHexString() behaves the same.

toHex(): string {
  return typeConversion.bigIntToHex(this);
}

toHexString(): string {
  return typeConversion.bigIntToHex(this);
}

However, in my thoughts toHex() should return a string that looks like deadbeef while toHexString() should return a string that looks like 0xdeadbeef.

So the implementation should be updated into:

toHex(): string {
  return typeConversion.bigIntToHex(this);
}

toHexString(): string {
  return "0x" + typeConversion.bigIntToHex(this);
}

Additionally, toHexString() is not tracked by The Graph's AssemblyScript API docs.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 890385b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[maoueh]

Will not merge in this form, and if AssemblyScript don't accept default parameter, we might even probably close this PR.

[maoueh]

This will be a major breaking change, while I kind of agree that we could have both I don't think we can merge that.

If AssemblyScript accepts default parameter, maybe we could think of toHexString(format) where default would be the same as today keeping compatibility and the format could be plain or prefixed or something along this.

[fewwwww]

Thanks for the review and feedback! I've updated the change with an optional prefix that does not affect the compatibility.