-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove provider checks at startup #5337
Open
mangas
wants to merge
16
commits into
master
Choose a base branch
from
filipe/remove-start-provider-checks
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
changed the title
Remove provider checks at startup
Remove provider checks at startup [WIP]
Apr 11, 2024
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
3 times, most recently
from
April 15, 2024 16:20
4d95fd8
to
64963c5
Compare
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
2 times, most recently
from
April 22, 2024 13:23
b486f8a
to
1c43770
Compare
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
8 times, most recently
from
May 13, 2024 10:41
9ad4249
to
d6c76f8
Compare
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
from
May 13, 2024 15:20
f15c7dd
to
002def6
Compare
mangas
changed the title
Remove provider checks at startup [WIP]
Remove provider checks at startup
May 13, 2024
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
3 times, most recently
from
May 14, 2024 09:32
cdfca0f
to
c4886a3
Compare
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
from
May 14, 2024 15:11
c4886a3
to
c9784a8
Compare
fordN
requested review from
incrypto32 and
zorancv
and removed request for
lutter
May 14, 2024 15:56
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
from
May 16, 2024 10:30
c828c7d
to
d3a0e68
Compare
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
from
May 17, 2024 14:38
808fd97
to
ec0306a
Compare
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
8 times, most recently
from
May 27, 2024 12:48
09c935d
to
fd56134
Compare
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
from
May 28, 2024 07:51
fd56134
to
4980841
Compare
mangas
force-pushed
the
filipe/remove-start-provider-checks
branch
from
May 28, 2024 17:24
4980841
to
380de39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3937
ChainIdentifier::default()
on startProviderManager
ProviderManager
if the ident returned is not the expected value.ChainClient
and tries to get an adapter with each poll, this means it won't stop if the first poll failsNetworks
type.Future improvements: