Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove provider checks at startup #5337

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Apr 11, 2024

Fixes #3937

  • New chain now created with ChainIdentifier::default() on start
  • Adapter genesis+net_version now checked by ProviderManager
  • Adapter checks will be disabled temporarily after an intermittent failure
  • Adapter won't be returned by the ProviderManager if the ident returned is not the expected value.
  • BlockIngestor now takes a ChainClient and tries to get an adapter with each poll, this means it won't stop if the first poll fails
  • node/src/main.rs refactored so that most of the init code is automatically executed by the new Networks type.
  • graphman run now uses the same init code as the node, should be able to run using any chain
  • EthereumNetworks type removed
  • FirehoseNetworks type removed
  • New chains require a working adapter for creation

Future improvements:

  • Cache genesis once it's set
  • Cache chain ident once it's set

@mangas mangas marked this pull request as draft April 11, 2024 09:09
@mangas mangas changed the title Remove provider checks at startup Remove provider checks at startup [WIP] Apr 11, 2024
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch 3 times, most recently from 4d95fd8 to 64963c5 Compare April 15, 2024 16:20
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch 2 times, most recently from b486f8a to 1c43770 Compare April 22, 2024 13:23
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch 8 times, most recently from 9ad4249 to d6c76f8 Compare May 13, 2024 10:41
@mangas mangas marked this pull request as ready for review May 13, 2024 15:11
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch from f15c7dd to 002def6 Compare May 13, 2024 15:20
@mangas mangas changed the title Remove provider checks at startup [WIP] Remove provider checks at startup May 13, 2024
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch 3 times, most recently from cdfca0f to c4886a3 Compare May 14, 2024 09:32
@mangas mangas requested a review from lutter May 14, 2024 09:35
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch from c4886a3 to c9784a8 Compare May 14, 2024 15:11
@fordN fordN requested review from incrypto32 and zorancv and removed request for lutter May 14, 2024 15:56
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch from c828c7d to d3a0e68 Compare May 16, 2024 10:30
@fordN fordN requested review from lutter and removed request for incrypto32 May 16, 2024 15:41
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch from 808fd97 to ec0306a Compare May 17, 2024 14:38
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch 8 times, most recently from 09c935d to fd56134 Compare May 27, 2024 12:48
@mangas mangas requested a review from lutter May 27, 2024 13:17
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch from fd56134 to 4980841 Compare May 28, 2024 07:51
@mangas mangas force-pushed the filipe/remove-start-provider-checks branch from 4980841 to 380de39 Compare May 28, 2024 17:24
@fordN fordN requested review from incrypto32 and removed request for lutter May 30, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make graph-node tolerate chains not being available during startup
2 participants