Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spark 3.5.0 support #436

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Conversation

EnricoMi
Copy link
Contributor

@EnricoMi EnricoMi commented Sep 13, 2023

Waiting for Spark 3.5.0 release...

Copy link
Contributor

@eejbyfeldt eejbyfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awsome!

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Merging #436 (30f21e3) into master (1573395) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files          18       18           
  Lines         828      828           
  Branches       55       55           
=======================================
  Hits          756      756           
  Misses         72       72           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EnricoMi EnricoMi marked this pull request as draft September 13, 2023 15:20
@EnricoMi EnricoMi marked this pull request as ready for review September 27, 2023 07:22
@EnricoMi
Copy link
Contributor Author

@WeichenXu123 PySpark 3.5.0 has been released, graphframes is ready to move to Spark 3.5.0.

@WeichenXu123
Copy link
Contributor

@EnricoMi Thanks! I just released graphframe 0.8.3 for spark 3.4 yesterday. Would you help adding CI for spark 3.5 ? then I will release a new version for spark 3.5

@EnricoMi
Copy link
Contributor Author

Would you help adding CI for spark 3.5 ?

Sure, what else is needed other than this PR?

@WeichenXu123
Copy link
Contributor

WeichenXu123 commented Sep 28, 2023

Would you help adding CI for spark 3.5 ?

Sure, what else is needed other than this PR?

Nothing else is needed. CI is for confirming graphframe is compatible with spark 3.5.

@WeichenXu123 WeichenXu123 merged commit e54f249 into graphframes:master Sep 30, 2023
12 checks passed
@EnricoMi EnricoMi deleted the spark-3.5 branch September 30, 2023 10:45
.setIntermediateStorageLevel(storageLevel)
.run()
assertComponents(components, expected)
// disabling adaptive query execution helps assertComponents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The need for this change here looks like a correctness bug in Spark 3.5.0. I created a PR with a attempted fix here: apache/spark#43188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants