chore(compiler): Make locs on anf_helper non optional
#1942
+548
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
peblair and
phated
as code owners
phated
requested changes
Dec 31, 2023
There was a problem hiding this comment.
Thanks for doing this @spotandjake! I wonder if it is actually better to use this diff as a way for @ospencer and @peblair to inventory the usage of dummy_loc 🤔
There are other cases of it being used in the compiler that I think might be worth inventorying as well. |
alex-snezhko
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr makes locations non optional on
anf_helper.I think after this is merged we might want to open an issue to go through and evaluate the use of
Location.dummy_locthroughout the compiler.