Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array: encourage use of List; show literal syntax #267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chadoh
Copy link

@chadoh chadoh commented Dec 3, 2021

I think this is a good start to a more useful intro to Array. I don't know enough about why I would use Array vs List to add that info myself, but I think it should be here and on the List page.

I think this is a good start to a more useful intro to Array. I don't know enough about why I would use Array vs List to add that info myself, but I think it should be here and on the List page.
@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy preview ready! 🌾

🔨 Explore the source changes: 88f5ec2

🔍 Inspect the deploy log: https://app.netlify.com/sites/grain-lang/deploys/61aa35343498b20007a842d1

😎 Browse the preview: https://deploy-preview-267--grain-lang.netlify.app/docs/stdlib/array

@ospencer
Copy link
Member

ospencer commented Dec 8, 2021

Thanks @chadoh! We'll probably need to do some reworking of the buttons on the website to point to the right place, since the source of truth for this document actually exists in the main Grain repo now: https://github.com/grain-lang/grain/blob/main/stdlib/array.md 😅

There's going to be quite a bit of work done to the website soon, so we'll probably take care of that then.

I'm not sure that this information makes sense on this page though, since it's a document for the standard library rather than a document on arrays. I think that what we're really missing is a page on arrays/loops in the guide. I hope to get some more documentation written soon, but if you're feeling particularly up to it, you could create that page!

@spotandjake
Copy link
Member

spotandjake commented Dec 8, 2021

Thanks @chadoh! We'll probably need to do some reworking of the buttons on the website to point to the right place, since the source of truth for this document actually exists in the main Grain repo now: https://github.com/grain-lang/grain/blob/main/stdlib/array.md 😅

There's going to be quite a bit of work done to the website soon, so we'll probably take care of that then.

I'm not sure that this information makes sense on this page though, since it's a document for the standard library rather than a document on arrays. I think that what we're really missing is a page on arrays/loops in the guide. I hope to get some more documentation written soon, but if you're feeling particularly up to it, you could create that page!

Correct me if I am wrong but this would probably be best placed under the list section in the guide for now or the language constructs whenever they get unhidden, a full walk through on syntax would be good though eventually in the guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants