Upgrade Binaryen #32
Closed
Upgrade Binaryen #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might need |
|
And the CI should fail with the errors I'm seeing. |
|
Oh yup, I'll hit this in a bit. |
Update bindings for breaking changes
ospencer
approved these changes
Oct 27, 2020
|
We can't upgrade Binaryen for the JS bindings because of this WebAssembly/binaryen#2990 (comment) |
phated
force-pushed
the
update-binaryen
branch
from
db608be
to
6153632
Compare
phated
force-pushed
the
update-binaryen
branch
from
927a8d6
to
a890e8b
Compare
phated
force-pushed
the
master
branch
2 times, most recently
from
5909560
to
a10a41d
Compare
|
Superseded by #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to upgrade binaryen (and we should track this more regularly) for a bunch of fixes that we need to possibly get this to work on Windows.
I've begun upstreaming those changes, but our bindings break when pulling them into this project. This seems to be due to breaking changes that happened since we wired up our submodules. I tracked one of the changes back to WebAssembly/binaryen@2841edd - but I'm going to need @ospencer's expertise to get things actually working.
This is a blocker on my further work to get Windows builds working.