Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Update to libbinaryen v114 #198

Merged
merged 6 commits into from Oct 30, 2023
Merged

feat!: Update to libbinaryen v114 #198

merged 6 commits into from Oct 30, 2023

Conversation

peblair
Copy link
Member

@peblair peblair commented Oct 24, 2023 •
edited

Unsure if this is breaking.

@peblair peblair changed the title Update to libbinaryen v114 feat: Update to libbinaryen v114 Oct 24, 2023
@phated
Copy link
Member

phated commented Oct 25, 2023

This needs the .expected file updated and needs the new pass added.

@phated phated changed the title feat: Update to libbinaryen v114 feat!: Update to libbinaryen v114 Oct 29, 2023
@phated phated mentioned this pull request Oct 30, 2023
Merged
phated
phated approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good (just waiting on JS + Windows on grain CI)

@phated phated merged commit d11b8e1 into master Oct 30, 2023
24 checks passed
@phated phated deleted the philip/update_v114 branch October 30, 2023 03:19
@github-actions github-actions bot mentioned this pull request Oct 30, 2023
Merged
@phated phated restored the philip/update_v114 branch October 30, 2023 03:20
@phated phated deleted the philip/update_v114 branch October 30, 2023 04:10
@grainbot grainbot mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peblair @phated