thought of how to address "alternatives" to fix inconsistency #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, what m3u8 package calls alternatives seem to be handled inconsistently. Namely, only the first "variant" after the set of alternatives gets the alternative and if the altneratives are at the end of the file, none get them.
|
the breaks somethings (i.e. is not complete), but is pushed as a POC in terms of perhaps a better API. With that said, even with that, I'm not sure how it should work with multiple groups of alternatives, I'm not sure it matters so much (the end user can figure it out via group tag), but the current code doesn't work for real life cases at the moment either. |
too much flipping between go and other languages with case fallthrough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, what m3u8 package calls alternatives seem to be handled inconsistently. Namely, only the first "variant" after the set of alternatives gets the alternative and if the altneratives are at the end of the file, none get them.