containeranalysis: close grpcClient #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `containeranalysis.NewClient()`, we allocate a containeranalysis client, but only use the `.GetGrafeasClient()` member. This results in leaking the containeranalysis client's connection pool, whenever a new client is created. Longer term, we should look at reusing connections as an alternative solution to this leak: there are other performance advantages. Co-Authored-By: Brian Chen <brian.chen@shopify.com> Co-Authored-By: Aline Shulzhenko <lynnsh@users.noreply.github.com>
|
_lynnsh noted from https://pkg.go.dev/cloud.google.com/go/containeranalysis/apiv1#Client.GetGrafeasClient
I think that comment is out of date, opened googleapis/google-cloud-go#5217 to confirm or deny this. |
dani-santos-code
approved these changes
Dec 14, 2021
thepwagner
commented
Dec 15, 2021
dani-santos-code
approved these changes
Dec 15, 2021
|
This is behaving great in our test environment, |
and closing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
containeranalysis.NewClient(), we allocate a containeranalysisclient, but only use the
.GetGrafeasClient()member.This results in leaking the containeranalysis client's connection pool,
whenever a new client is created.
Longer term, we should look at reusing connections as an alternative
solution to this leak: there are other performance advantages.
Co-Authored-By: Brian Chen brian.chen@shopify.com
Co-Authored-By: Aline Shulzhenko lynnsh@users.noreply.github.com
Related