JWK Implementation for import/export #61
Conversation
olegbespalov
force-pushed
the
feat/jwk
branch
from
e284c5e
to
575b54d
Compare
olegbespalov
requested review from
oleiade and
joanlopez
and removed request for
a team
olegbespalov
changed the title
olegbespalov
force-pushed
the
feat/jwk
branch
from
575b54d
to
8ff0bd5
Compare
|
Before I forget, we should also update the README tables to match the newly introduced support for JWK in |
| import { crypto } from "k6/x/webcrypto"; | ||
|
|
||
| export default async function () { | ||
| try { |
There was a problem hiding this comment.
Stupid question; why do this example is surrounded by a try..catch, while other (e.g. import-export-jwk-aes-key.js) isn't, if the operations are the same? 🤔
There was a problem hiding this comment.
It's the other way around, I think it's just copy-paste issue, I will adjust the import-export-jwk-aes-key.js to also have a try...catch, which won't harm 👍
webcrypto/aes.go
Outdated
| // check the key length | ||
| var ( | ||
| has128Bits = len(keyData) == 16 | ||
| has192Bits = len(keyData) == 24 | ||
| has256Bits = len(keyData) == 32 | ||
| ) | ||
|
|
||
| if !has128Bits && !has192Bits && !has256Bits { | ||
| return nil, NewError(DataError, fmt.Sprintf("invalid key length %v bytes", len(keyData))) | ||
| } |
There was a problem hiding this comment.
Nit; this can be hide behind a method, similar to isHashAlgorithm
webcrypto/jwk.go
Outdated
| return nil, fmt.Errorf("failed to marshal JWK key: %w", err) | ||
| } | ||
|
|
||
| // wrap result result into the object that is expected to be returned |
There was a problem hiding this comment.
| // wrap result result into the object that is expected to be returned | |
| // wrap result into the object that is expected to be returned |
| return promise | ||
| } | ||
| default: | ||
| reject(NewError(ImplementationError, "unsupported format "+format)) |
There was a problem hiding this comment.
| reject(NewError(ImplementationError, "unsupported format "+format)) | |
| reject(NewError(ImplementationError, "unsupported format "+format)) | |
| return promise |
Shouldn't we return the promise here as well, as we do for the rest of the error cases? 🤔
There was a problem hiding this comment.
Yes, we should! Great catch!
|
|
||
| b, ok := result.([]byte) | ||
| if !ok { | ||
| reject(NewError(ImplementationError, "for "+format+" []byte expected as result")) |
There was a problem hiding this comment.
Similar to the comment above, should we return here right after the reject? 🤔
What?
This is an implementation of the JWK export/import.
I've decided to use the popular library instead of self-tailored since, for the following algorithms, the JWK could be more complicated in terms of maintaining standards.
How did I test it?
Related PRs:
This PR is based on #62
Why?
JWK is part of the specification.
Closes: #37