Skip to content

Commit

Permalink
Note that first person plural is fine when referring to Grafana Labs (#…
Browse files Browse the repository at this point in the history
…649)

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>
  • Loading branch information
jdbaldry and imatwawana committed May 3, 2024
1 parent 3288075 commit 69b66bd
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 12 deletions.
11 changes: 0 additions & 11 deletions vale/Grafana/GoogleWe.yml

This file was deleted.

16 changes: 16 additions & 0 deletions vale/Grafana/We.yml
@@ -0,0 +1,16 @@
extends: existence
message: |
Use first person plural pronouns like '%s' carefully.
Don't use 'we' when you're talking about the reader, instead use 'you'.
It's OK to use 'we' when you're talking about Grafana Labs.
link: https://developers.google.com/style/person#use-first-person-plural-pronouns-carefully
level: warning
ignorecase: true
tokens:
- we
- we'(?:ve|re)
- ours?
- us
- let's
3 changes: 2 additions & 1 deletion vale/google.jsonnet
Expand Up @@ -36,7 +36,8 @@ std.prune({
'Grafana/GoogleSpelling.yml': std.manifestYamlDoc(std.parseYaml(importstr 'Google/Spelling.yml')),
// More often than not, we need to be consistent with Prometheus units or units used Grafana UI which are not represented in the form encouraged by SI.
'Grafana/GoogleUnits.yml': null,
'Grafana/GoogleWe.yml': std.manifestYamlDoc(std.parseYaml(importstr 'Google/We.yml')),
// Replaced by Grafana/We.yml.
'Grafana/GoogleWe.yml': null,
'Grafana/GoogleWill.yml': std.manifestYamlDoc(std.parseYaml(importstr 'Google/Will.yml') {
message: super.message + '\n\n' + |||
Use present tense for statements that describe general behavior that's not associated with a particular time.
Expand Down

0 comments on commit 69b66bd

Please sign in to comment.