Use _#schema to generate TS files #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Glad we finally got this sorted! Let's use this as an excuse to introduce some simple corpus tests for ts as well - same as we have for |
joanlopez
reviewed
Jul 25, 2023
joanlopez
reviewed
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It rollback to the previous implementation since we need to use
_#schema.If you need some context:
_#schemais a union between theschemaand the_joinvalue. We need this_joinvalue to merge any extra information to the user's schemas (for example, validators).For any reason,
Cuetsydidn't like this union and it was unable to find the extends for the interfaces. We decided to split_#schemavalues temporally and merge them later to make it works. Finally we have a fix inCuetsyto make it works.